[Webkit-unassigned] [Bug 40627] Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40627





--- Comment #30 from Joseph Pecoraro <joepeck at webkit.org>  2010-07-26 15:24:12 PST ---
> > diff --git a/WebCore/loader/appcache/ApplicationCacheStorage.h b/WebCore/loader/appcache/ApplicationCacheStorage.h
> > +    static const int64_t noQuota = INT64_MAX;
> 
> It's unfortunate that this constant isn't "-1" since it's a signed value.  Has this ship already sailed for existing users?

I few points on this int64 part:

  - session storage uses the max as noQuota, so I went with the flow.
  - this is signed only because SQLite doesn't store unsigned. I thought about this later, and
    I think this value should actually be unsigned, and I check and log cases where the value
    attempts to be set more than INT64_MAX.
  - I actually use -1 later on to mean "unknown" or "not set" rather than using a boolean.

Also the build bots don't like INT64_MAX on other platforms. Do you know of a
platform independent constant I can use? Using numeric_limit<int64_t> gave
me a warning at compile time.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.