[Webkit-unassigned] [Bug 43008] New: Simplify speech input plumbing in webcore and webkit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 26 15:01:15 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=43008

           Summary: Simplify speech input plumbing in webcore and webkit
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Forms
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: satish at chromium.org


A few related changes to make things simpler with the speech input plumbing between WebCore <> WebKit. This will help in subsequent patches for adding testing/mocking code and the mac/linux port implementation.

- Each WebCore::InputFieldSpeechButtonElement object was creating one WebCore::SpeechInput object for accessing the WebKit speech client, and there were 2 listener interfaces involved. Instead, now WebCore::Page creates only 1 instance of WebCore::SpeechInput and WebCore::InputFieldSpeechButtonElement calls the webkit APIs through this object.
- WebKit::SpeechInputClientImpl was having some intelligence to deal with starting speech recognition when another instance was already running. This has now been moved to the above mentioned WebCore::SpeechInput object which WebCore::Page maintains. With this change, WebKit::SpeechInputClientImpl becomes a dumb proxy between WebCore and the WebKit.
- Added necessary methods to WebCore::SpeechInput and WebCore::SpeechInputClient so that the above mentioned functionality can be moved from WebKit::SpeechInputClientImpl to WebCore::SpeechInput.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list