[Webkit-unassigned] [Bug 38050] Form button input elements lacking text in some cases after switching from visibility:collapse to visibility:visible

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=38050





--- Comment #13 from Ben Murdoch <benm at google.com>  2010-07-26 12:06:32 PST ---
(In reply to comment #12)
Hi Simon,

Thanks for the comments and suggestions!

> (From update of attachment 58141 [details])
> This is an OK way to do it, but rather than complexificate adjustStyleDifference(), you could just move this code to RenderStyle::diff(), and use display() == BOX to detect whether you're dealing with a flexbox.

Hmm, display() == BOX doesn't seem to be working :( I've moved the code into RenderStyle::diff() and it works without that check. But as Mitz pointed out earlier in comment 7, it would be better to only force a layout when we are dealing with flexboxes. Any other suggestions as to how I could detect a flexbox? Or is this infact not such a big concern?

> 
> Be sure to add your code between the last 'return StyleDifferenceLayout' and the first 'return StyleDifferenceRepaintLayer'.

Will do!

Thanks, Ben

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.