[Webkit-unassigned] [Bug 37698] Line not wrapped at certain punctuations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37698


mitz at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--- Comment #15 from mitz at webkit.org  2010-07-26 11:40:50 PST ---
(In reply to comment #14)
> I created a test to compare the performance of the following configurations:
> 1) original code
> 2) new code with packing
> 3) new code without packing
> 
> All configurations are run 1000 times to calculate line breaking opportunities between all adjacent chars in break_lines.cpp itself. The differences among the timings are very small (<5%).

Thank you for testing! The results are a little vague. Did this register as slower than the original code in your test? If so, did you test the impact on any page-loading test?

> > To me, the expression
> >                b & (1 << (nextChIndex % 8))
> > (with a corresponding change to the B macro) is clearer than the one you wrote, but I guess that’s just a matter of personal preference.
> >
> 
> Done. B macro doesn't need change.

Thanks. I confused myself into believing it needed to change.

> > Have you tested this patch for performance impact?
> 
> Done. See above about byte packing and shifting.

I want to r+ the patch but I still have some concerns about performance. Please answer my question above. Thanks again!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.