[Webkit-unassigned] [Bug 42984] New: webkit-patch post-commits is broken: AttributeError: Values instance has no attribute 'no_squash'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42984

           Summary: webkit-patch post-commits is broken: AttributeError:
                    Values instance has no attribute 'no_squash'
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ddkilzer at webkit.org
                CC: eric at webkit.org, abarth at webkit.org, ojan at chromium.org


$ ./WebKitTools/Scripts/webkit-patch post-commits -m "Patch v1" HEAD
Traceback (most recent call last):
  File "./WebKitTools/Scripts/webkit-patch", line 64, in <module>
    main()
  File "./WebKitTools/Scripts/webkit-patch", line 59, in main
    WebKitPatch(__file__).main()
  File "/Volumes/Data/WebKit.git/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/Data/WebKit.git/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/Data/WebKit.git/WebKitTools/Scripts/webkitpy/tool/commands/upload.py", line 288, in execute
    steps.ObsoletePatches(tool, options).run(state)
  File "/Volumes/Data/WebKit.git/WebKitTools/Scripts/webkitpy/tool/steps/abstractstep.py", line 38, in __init__
    if options.no_squash:
AttributeError: Values instance has no attribute 'no_squash'

Note that "upload" keeps opening an editor for a patch that already has a ChangeLog, which is not what I want either:

./WebKitTools/Scripts/webkit-patch upload -m "Patch v1" -g HEAD

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.