[Webkit-unassigned] [Bug 34804] Some WTF headers fail to compile under VS2010 RC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34804





--- Comment #8 from Adam Roben (aroben) <aroben at apple.com>  2010-07-26 10:38:20 PST ---
(In reply to comment #4)
> I do not think you should disable this warning in common.vsprops because accordingly to Microsoft: "The compiler issues warning C4396 and IGNORES THE INLINE SPECIFIER." http://msdn.microsoft.com/en-us/library/bb384968.aspx
> I am pretty sure that VS2005 compiler as well as many others also ignored inline specifier in that particular case, but without warning. :)

I think the way to make a decision here is roughly:

* Does any compiler honor the inline specifier on adoptRef?
   * No: we should just remove it
   * Yes:
      * Does removing the inline specifier have any negative effects for those compilers which honor it?
         * No: we should just remove it
         * Yes: we should ignore the warning

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.