[Webkit-unassigned] [Bug 42811] Geolocation preemptive permissions policy is buggy

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42811


Mahesh Kulkarni <mahesh.kulkarni at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|mahesh.kulkarni at nokia.com   |webkit-unassigned at lists.web
                   |                            |kit.org




--- Comment #3 from Mahesh Kulkarni <mahesh.kulkarni at nokia.com>  2010-07-26 10:13:50 PST ---
(In reply to comment #2)

Thanks for the review Steve. 

> (From update of attachment 62572 [details])
> > ChangeLog
> > +          No new test content added
> I think this warrants a new test. Unfortunately I think that requires a fix to the Mac LayoutTestController which is being done in Bug 40002. I'll try to get that bug fixed soon.

Ok few new test cases for multiple notifiers waiting permission. Do you think its good idea to raise a different bug for these new cases and mark blocked by 40002?

> 
> > Geolocation.cpp: 415
> > page->geolocationController()->addObserver(this);
> This should be in the above loop. Can you also add a FIXME to pass options to the client, as at line 635.
> 

ok, so its number of listeners for controller. Will update this in patch.

> > Geolocation.cpp: 417
> > // TODO: Handle startUpdate() for non-client based implementations using pre-emptive policy
> This patch should just fix this bug - the problems with the existing code. Let's leave adding the new code for !CLIENT_BASED && PREEMPT for Bug 42027.

ok make sense. Will take care of this

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.