[Webkit-unassigned] [Bug 42834] Clients for optional features should be passed to Page constructor via structure of pointers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42834





--- Comment #10 from Steve Block <steveblock at google.com>  2010-07-26 09:03:34 PST ---
> IIRC in the webkit-dev thread Darin and Eric suggested not to zero initialize
> the pointers,
It's true that Eric suggested this, but to do so would erase come of the benefits of this approach. Without zero initialisation, for every new feature, all ports would have to explicitly set the client, even when setting the client to null when the feature is not enabled.

> and that we should perhaps make sure all the clients are valid
> when passed in.
Sure, that seems like a good idea, but I think it's independent of this change. Currently, platforms pass many null clients for features that are not enabled. We only require clients to be non-null if the feature is enabled, as mentioned in the comment in Page.h. This patch doesn't change anything with regard to the need to check that clients for enabled features are non-null.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.