[Webkit-unassigned] [Bug 40909] Support WTF::Vector pretty printer for GDB 7

Mon Jul 26 06:30:26 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=40909

Shinichiro Hamaji <hamaji at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62563|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |

--- Comment #10 from Shinichiro Hamaji <hamaji at chromium.org>  2010-07-26 06:30:26 PST ---
(From update of attachment 62563)
Looks good. Thanks for your update!

> I don't think it is worth hiding 'pretty_printer_dict' from global scope. 'pretty_printer_dict' is global, but that is global only within this module. I'd like to leave that as is because that won't conflict any variables defined in other modules.

I still like not to use global variables because I was a bit surprised this code seemed to use a variable without declaration. At first, I guessed pretty_printers_dict is something special in GDB extensions. But it's OK as is.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.