[Webkit-unassigned] [Bug 42612] DRT should allow test scripts to access WebCore internal states for setup/verification

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42612





--- Comment #11 from MORITA Hajime <morrita at google.com>  2010-07-25 23:19:06 PST ---
HI ojan, thank you for reviewing!

(In reply to comment #8)
> I think we should call the new class LayoutTestControllerWebCore though. Just saying "Core" is too vague (e.g. that could also be JavaScriptCore).
I agree that the name "WebCore::LayoutTestControllerCore" is strange. but  
"WebCore::LayoutTestControllerWebCore" looks redundant. 
So I just renamed it to "WebCore::LayoutTestController". 
(In our convention, original LayoutTestController shoud be named
WebLayoutTestController so something. But it's too late.)

> > +    int documentMakerSizeForNode(Node*, ExceptionCode&) const;
> > +    String documentMakerStringForNodeAt(Node*, int, ExceptionCode&) const;
> 
> Did you mean documentMarker* here?
Oops. You're right. Thank you pointing this out. Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.