[Webkit-unassigned] [Bug 42323] WebKitTestRunner needs to support layoutTestController.keepWebHistory

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42323


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-07-25 22:49:17 PST ---
Attachment 62543 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundle.h:63:  _didReceiveMessage is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/TestController.h:70:  _didReceiveMessageFromInjectedBundle is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.h:46:  Extra space between WKBundleDidReceiveMessageCallback and didReceiveMessage  [whitespace/declaration] [3]
WebKit2/UIProcess/API/C/WKContext.h:41:  Extra space between WKContextDidReceiveMessageFromInjectedBundleCallback and didReceiveMessageFromInjectedBundle  [whitespace/declaration] [3]
WebKitTools/WebKitTestRunner/TestController.cpp:129:  TestController::_didReceiveMessageFromInjectedBundle is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:60:  InjectedBundle::_didReceiveMessage is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 6 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.