[Webkit-unassigned] [Bug 42933] Cleanup defines in Platform.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42933


Patrick R. Gansterer <paroga at paroga.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62500|review-, commit-queue-      |review?, commit-queue?
               Flag|                            |




--- Comment #3 from Patrick R. Gansterer <paroga at paroga.com>  2010-07-24 12:44:03 PST ---
(From update of attachment 62500)
(In reply to comment #2)
> (From update of attachment 62500 [details])
> > -#if PLATFORM(WIN)
> > +#if PLATFORM(WIN) && !OS(WINCE)
> 
> Why does this matter? Is PLATFORM(WIN) ever true when OS(WINCE) is also true? I think this part of the change is wrong.
WinCE+GDI defines PLATFORM(WIN), so it is correct.

Cleaning up the PLATFORM() checks for WinCE is IMHO an other task. (e.g. There a too many OS(WINCE) && !PLATFORM(QT))

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.