[Webkit-unassigned] [Bug 42935] [MSVC] Ensure 4 byte alignment on ARM

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42935


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62502|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2010-07-24 12:41:23 PST ---
(From update of attachment 62502)
> +#if COMPILER(MSVC)
> +#pragma pack(push)
> +#pragma pack(4)
> +#endif // COMPILER(MSVC)

I think having a comment on an endif that is only 2 lines away from the #if is overkill!

> +#if COMPILER(MSVC)
> +#pragma pack(pop)
> +#endif // COMPILER(MSVC)

And even moreso here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.