[Webkit-unassigned] [Bug 39989] Applying inline style to a text node whose parent is an inline editable root causes crash

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 24 12:35:59 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=39989





--- Comment #10 from Ryosuke Niwa <rniwa at webkit.org>  2010-07-24 12:35:59 PST ---
Created an attachment (id=62507)
 --> (https://bugs.webkit.org/attachment.cgi?id=62507)
cleans up splitText(Element)At(Start|End)IfNeed and fixes the bug

Work in progress.  This patch moves "IfNeeded" check from splitText(Element)AtEndIfNeed and isolate as isValidCaretPositionInTextNode, thanks to Eric Seidel's patch for the bug 25056.  I then made splitTextElementAt(Start|End) smarter by adding a check to see if the parent of the element we're about to split is editable (if the element itself was the root editable element, then we can't split).  If the check fails, we only split the text node, which is always possible.

This patch can be split into cleanup and actual fix.  It also requires rebaseline of editing/execCommand/hilitecolor.html and editing/style/remove-underline-from-stylesheet.html but we must wait for my patch for the bug 42793 to be landed because hilitecolor.html is a currently render test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list