[Webkit-unassigned] [Bug 42885] [WINCE] Merge PasteboardWince.cpp into PasteboardWin.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42885


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62409|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #3 from Adam Roben (aroben) <aroben at apple.com>  2010-07-23 08:31:48 PST ---
(From update of attachment 62409)
>  Pasteboard::Pasteboard()
> -{ 
> -    // make a dummy HWND to be the Windows clipboard's owner
> -    WNDCLASSEX wcex = {0};
> +{
> +    HWND hWndParent = 0;
> +#if OS(WINCE)
> +    WNDCLASS wcex;
> +    memset(&wcex, 0, sizeof(WNDCLASS));
> +#else
> +    WNDCLASSEX wcex;
> +    memset(&wcex, 0, sizeof(WNDCLASSEX));
>      wcex.cbSize = sizeof(WNDCLASSEX);
> +#endif
>      wcex.lpfnWndProc    = PasteboardOwnerWndProc;
> -    wcex.hInstance      = WebCore::instanceHandle();
>      wcex.lpszClassName  = L"PasteboardOwnerWindowClass";
> -    ::RegisterClassEx(&wcex);
> +#if OS(WINCE)
> +    RegisterClass(&wcex);
> +#else
> +    RegisterClassEx(&wcex);
> +    hWndParent = HWND_MESSAGE;
> +#endif

I think we can make non-CE Windows use WNDCLASS and RegisterClass, too. I think the reduced complexity is worth it.

Why was the setting of the hInstance member removed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.