[Webkit-unassigned] [Bug 42888] [WINCE] Buildfix for GraphicsContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42888


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62410|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #3 from Adam Roben (aroben) <aroben at apple.com>  2010-07-23 08:12:42 PST ---
(From update of attachment 62410)
In the future, it would be helpful for you to use svn-create-patch rather than plain "svn diff" to create your patches. The former does a few things to make the patches slightly easier to read (like putting function names above each chunk).

> @@ -1268,7 +1268,7 @@
>      
>      IntRect dstRect = fillRect;
>      
> -    dstRect.move(shadowSize);
> +    dstRect.move(shadowSize.width(), shadowSize.height());

Is truncating to int really the right thing to do here?

r=me, but I'll wait for an answer before marking this cq+.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.