[Webkit-unassigned] [Bug 40328] GtkLauncher fails to build: Undefined references to openFile, readFromFile, and seekFile

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40328


Kent Hansen <kent.hansen at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |Gtk
                 CC|                            |kent.hansen at nokia.com




--- Comment #8 from Kent Hansen <kent.hansen at nokia.com>  2010-07-23 07:04:13 PST ---
(In reply to comment #7)
> (In reply to comment #6)
> > (From update of attachment 58536 [details] [details])
> > This is not an official review, but i would like to give some hints.
> 
> Thank you very much, Dirk.  I'll make all these fixes.
> 
> As of now I don't know how to work with layouttests.  I need to review and digest the "Writing New Tests" webpage and then find time to do the work -- which may not happen until sometime next week :^(
> 
> Thanks again.
> 
> Clemmitt

Hi Clemmitt,
Please turn off the review flag if you don't intend to have the current patch reviewed anymore. That stops it from showing up in the list of patches pending review.

I've also added the gtk keyword to this bug, since it's more likely to be spotted by gtk devs then.

As you commented already, the FileReader class was added in http://trac.webkit.org/changeset/58832, but it's still off by default. So the workaround until a gtk patch is landed is to build without that feature (--no-file-reader, or just don't pass --file-reader).

And I don't think you can write a LayoutTest for this; essentially the patch for the missing functions is needed in order to enable file-reader for the gtk port, and once that happens, the entry for fast/files/file-reader.html can be removed from platform/gtk/Skipped.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.