[Webkit-unassigned] [Bug 42873] Web Inspector: error info propagation in InspectorBackendDispatch should be improved

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42873


Ilya Tikhonovsky <loislo at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62398|review?                     |review+
               Flag|                            |




--- Comment #2 from Ilya Tikhonovsky <loislo at chromium.org>  2010-07-23 02:36:38 PST ---
(From update of attachment 62398)

WebCore/inspector/CodeGeneratorInspector.pm:245
 +      push(@function, "    if (args->length() != " . $expectedParametersCount . ") {");

can be simplified a bit.
push(@function, "    if (args->length() != $expectedParametersCount) {");


WebCore/inspector/CodeGeneratorInspector.pm:246
 +      push(@function, "        *exception = String::format(\"Wrong number of parameters: %d (expected: $expectedParametersCount)\", args->length());");
It would be better to also print the parameter name.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.