[Webkit-unassigned] [Bug 42254] ThreadSpecific (QThreadStorage) should not be deleted

Fri Jul 23 00:32:14 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=42254

Oliver Hunt <oliver at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61512|review?                     |review-
               Flag|                            |

--- Comment #4 from Oliver Hunt <oliver at apple.com>  2010-07-23 00:32:14 PST ---
(From update of attachment 61512)
There is no requirement that the first client of JSC be a browser, nor that alternate threads be workers.  JSC has multiple mac clients that use jsc off the main thread, and CFNetwork uses JSC for PAC files, so 
"// This function surely called from the main thread first,"
Is incorrect.

If you really felt that this should be persistent you would either have to add a lock on stackGuards or push it into initializeThreading (or whatever that function is called).

That said I don't understand why Qt has a requirement that thread specific data not ever be removed -- this code seems to work with pthreads, and with windows' thread specific storage so i'm not sure why qt doesn't.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.