[Webkit-unassigned] [Bug 42827] Use the js-execute-active(entered) Frame to check the user gesture of page instead of checking the top frame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42827


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62371|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #7 from Adam Barth <abarth at webkit.org>  2010-07-22 19:08:41 PST ---
(From update of attachment 62371)
WebCore/bindings/js/ScriptController.cpp:306
 +      return exec ? toDynamicFrame(exec) : 0;
This is dangerous.  The lexical frame is most likely to be the active frame.  The dynamic frame isn't used for very much beyond user gesture.

WebCore/loader/FrameLoader.cpp:1133
 +      Frame* enteredFrame = frame->script()->getActiveFrame();
We don't use the term "enteredFrame" outside the V8 bindings.

WebCore/loader/FrameLoader.cpp:1137
 +      return enteredFrame->script()->processingUserGesture(mainThreadNormalWorld()); // FIXME: Use pageIsProcessingUserGesture.
This is all way too complicated.  Every call site will need to do this dance.  Can't we push this junk into the bindings / ScriptController?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.