[Webkit-unassigned] [Bug 42612] DRT should allow test scripts to access WebCore internal states for setup/verification

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42612


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62260|review?                     |review-
               Flag|                            |




--- Comment #8 from Ojan Vafai <ojan at chromium.org>  2010-07-22 18:26:26 PST ---
(From update of attachment 62260)
Thanks for doing this. This is a big improvement over needing to implement the same API many times over. I don't really know JSC APIs well enough to know if there is a better way to do the inheritance. Someone else will need to review the code properly. I just have a few naming issues.

I think we should call the new class LayoutTestControllerWebCore though. Just saying "Core" is too vague (e.g. that could also be JavaScriptCore).

> +    int documentMakerSizeForNode(Node*, ExceptionCode&) const;
> +    String documentMakerStringForNodeAt(Node*, int, ExceptionCode&) const;

Did you mean documentMarker* here?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.