[Webkit-unassigned] [Bug 42861] New: Session history should skip over JS redirects

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 22 17:42:42 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=42861

           Summary: Session history should skip over JS redirects
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
               URL: http://persistent.info/webkit/test-cases/redirects/pag
                    e1.html
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: History
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: mihaip at chromium.org
                CC: fishd at chromium.org


Chrome currently has some logic to not add session history entries for pages that generate "machine" redirects (e.g. if foo.com has a window.location.href = '/page.html' JS snippet onload on soon after) - see http://crrev.com/18373. This logic shouldn't live in Chrome code (in navigation_controller.cc, etc.), it should instead be promoted to WebKit code.

Bug that this would fix (reproduced as of WebKit r63854):
1. Visit http://www.apple.com/
2. Visit http://www.hp.com/
3. Wait for JS redirect to http://www.hp.com/#Product (should happen <1 second after hp.com loads)
4. Press back

Expected result:
1. End up at http://www.apple.com/

Actual result:
1. End up at a 404 page on hp.com

Reduced test case at:

http://persistent.info/webkit/test-cases/redirects/page1.html

After waiting for the two redirects (ending up on page 3), pressing back should take you to page 1, not page 2.

Proposed fix is similar to http://crrev.com/18373: Don't add a session history entry if the navigation happens without a user gesture (click or key press) within the first 5 seconds after the page loads.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list