[Webkit-unassigned] [Bug 42834] Clients for optional features should be passed to Page constructor via structure of pointers

Thu Jul 22 15:14:39 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=42834

Steve Block <steveblock at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |steveblock at google.com

--- Comment #2 from Steve Block <steveblock at google.com>  2010-07-22 15:14:39 PST ---
This patch moves the following clients from Page constructor arguments to the new OptionalClients structure.
 - ContextMenuClient
 - DragClient
 - InspectorClient
 - GeolocationControllerClient
 - DeviceOrientationClient

It also changes the SpeechInputClient from being set via a setter method to being passed as part of the structure, to avoid there being a period of time where the client is not set.

It seems that some platforms pass null for the PluginHalterClient and BackForwardControllerClient, but these features do not seem to be controlled by an ENABLE flag, so I chose not to count them as optional.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.