[Webkit-unassigned] [Bug 41413] [Qt] QtWebKit needs public API for Notifications.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41413





--- Comment #17 from Yael <yael.aharon at nokia.com>  2010-07-22 07:26:21 PST ---
(In reply to comment #16)
> (From update of attachment 62289 [details])
Thanks for the review, Simon!
> WebKit/qt/Api/qwebpage.h:387
>  +      void checkPermissionFromUser(QWebFrame* frame, QWebPage::PermissionDomain domain, QWebPage::PermissionPolicy& policy);
> We usually don't use synchronous signals with out values in the Qt API.
> 
"policy" is the return value of this signal. Ideally, this would be a virtual function, but since we cannot add virtual functions to QWebPage, I made it a signal.
> Is this needed in places where a synchronous response is needed from the user and we can't fall back to the requestPermission -> setUserPermission flow?
yes.
Notifications have 2 types of checks. One is synchronous and one is asynchronous. The asynchronous check is expected to show a UI and the synchronous is not expected to show a UI. We cannot call the asynchronous API when the synchronous API is expected. 

I will create a new bug for the documentation of this new API and hope that with the documentation it will become more clear.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.