[Webkit-unassigned] [Bug 42721] [EFL] Set proxy address for Soup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42721





--- Comment #8 from Lucas De Marchi <lucas.demarchi at profusion.mobi>  2010-07-22 05:37:20 PST ---
(From update of attachment 62268)
> Index: WebKit/efl/ChangeLog
> ===================================================================
> --- WebKit/efl/ChangeLog	(revision 63877)
> +++ WebKit/efl/ChangeLog	(working copy)
> @@ -1,3 +1,18 @@
> +2010-07-22  Gyuyoung Kim  <gyuyoung.kim at samsung.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [EFL] Set proxy address for Soup
> +        https://bugs.webkit.org/show_bug.cgi?id=42721
> +
> +        Set proxy address by http_proxy enviroment variable.

Now the description doesn't make much sense.

> Index: WebKit/efl/ewk/ewk_settings.cpp
> ===================================================================
> --- WebKit/efl/ewk/ewk_settings.cpp	(revision 63876)
> +++ WebKit/efl/ewk/ewk_settings.cpp	(working copy)
> @@ -29,6 +29,7 @@
>  #include "Image.h"
>  #include "IntSize.h"
>  #include "KURL.h"
> +#include "NotImplemented.h"

There's no other place inside WebKit/efl/ewk/ where we use notImplemented(). I'd rather let this out and use a warning in eina_log or an EINA_SAFETY_ON_TRUE_RETURN(1).



> +/**
> + * Sets proxy address.
> + *
> + * @param proxy address. If proxy address is null, proxy address isn't set.
> + */
> +void ewk_settings_proxy_uri_set(const char* proxy)
> +{
> +#ifdef WTF_USE_SOUP
> +    SoupSession* session = WebCore::ResourceHandle::defaultSession();
> +    g_object_set(session, SOUP_SESSION_PROXY_URI, soup_uri_new(proxy), NULL);

You are leaking the SoupURI struct here, since g_object_set always copies. Change to something like:

SoupURI* uri = soup_uri_new(proxy);
EINA_SAFETY_ON_NULL_RETURN(uri);

g_object_set(session, SOUP_SESSION_PROXY_URI, uri, NULL);
soup_uri_free(soupUri);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.