[Webkit-unassigned] [Bug 5864] feTurbulence is not implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5864


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zimmermann at kde.org




--- Comment #11 from Nikolas Zimmermann <zimmermann at kde.org>  2010-07-22 02:16:35 PST ---
(In reply to comment #9)
> > WebCore/svg/graphics/filters/SVGFETurbulence.cpp:119
> >  +  inline long FETurbulence::PaintingData::random()
> > If you want to force inlining, use ALWAYS_INLINE here, consistent with the other filter effects.
> 
> I disagree -- ALWAYS_INLINE should only be used if there's a measurable benefit in doing so -- the inline keyword doesn't necessarily guarantee inlining, but it does guarantee sensible linker behaviour.  I don't like the overuse of ALWAYS_INLINE in the filter code.  The purpose of ALWAYS_INLINE is to prevent the compiler from being able to make its own decisions _if_ the compiler is making a measurably incorrect choice.  I have yet to see evidence of this occurring outside of JSC

Okay, I'll keep this in mind for doing any further reviews. But using "inline" would still be fine?
I think we should cleanup the use of ALWAYS_INLINE in the filter effects code, I have misinterpreted the macro, and thought one could always use it instead of inline.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.