[Webkit-unassigned] [Bug 42726] Refactor CSSSelector's destructor and make it inline.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42726





--- Comment #12 from Hayato Ito <hayato at chromium.org>  2010-07-21 22:02:36 PST ---
Thank you for the review. I've posted another patch which only fixed the comment issues.

(In reply to comment #10)
> (From update of attachment 62256 [details])
> > +        // rareData must be deleted here.
> > +        delete m_data.m_rareData;
> 
> This is not a very good comment. Good comments answer the question "why", while this just states that the code is needed without giving a reason.

I've removed the comment. I don't think it is important one.

> 
> > +            // We can not delete the owned object(s) by simply calling delete
> > +            // directory on them. It leads to recursive destrutor calls which
> 
> Typo here: "directory" but it should be "directly".
> 
> Typo here: "destrutor" but it should be "destructor".
> 
> Instead of "It leads" the sentence should say "That would lead".

Done. I am sorry for that. Thank you!

> 
> review+ because this patch is great except for the comment issues above, but I'll leave commit-queue on ? until you decide if you want to post another patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.