[Webkit-unassigned] [Bug 42726] Refactor CSSSelector's destructor and make it inline.

Wed Jul 21 21:35:25 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=42726

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62256|review?                     |review+
               Flag|                            |

--- Comment #10 from Darin Adler <darin at apple.com>  2010-07-21 21:35:25 PST ---
(From update of attachment 62256)
> +        // rareData must be deleted here.
> +        delete m_data.m_rareData;

This is not a very good comment. Good comments answer the question "why", while this just states that the code is needed without giving a reason.

> +            // We can not delete the owned object(s) by simply calling delete
> +            // directory on them. It leads to recursive destrutor calls which

Typo here: "directory" but it should be "directly".

Typo here: "destrutor" but it should be "destructor".

Instead of "It leads" the sentence should say "That would lead".

review+ because this patch is great except for the comment issues above, but I'll leave commit-queue on ? until you decide if you want to post another patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.