[Webkit-unassigned] [Bug 42783] Break out "scheme registration" functionality to a SchemeRegistry

Wed Jul 21 14:46:35 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=42783

Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62229|review?                     |review+
               Flag|                            |

--- Comment #2 from Geoffrey Garen <ggaren at apple.com>  2010-07-21 14:46:35 PST ---
(From update of attachment 62229)
WebCore/platform/SchemeRegistry.cpp:94
 +  
Boo on two names for the same thing. I would rename "localSchemes" to "localURLSchemes". (Requires a namespace qualification on the return statement.)

WebCore/platform/SchemeRegistry.cpp:106
 +  
Seems like these fast cases should assert that they're correct. Something like "ASSERT(localSchemes().contains(X))".

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.