[Webkit-unassigned] [Bug 42539] WebKitTestRunner needs to support printing ALERT, PROMPT and CONFIRM messages

Wed Jul 21 13:05:04 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=42539

WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com

--- Comment #3 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-07-21 13:05:04 PST ---
Attachment 62223 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:72:  Extra space between WKBundlePageWillAddMessageToConsoleCallback and willAddMessageToConsole  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:73:  Extra space between WKBundlePageWillSetStatusbarTextCallback and willSetStatusbarText  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:74:  Extra space between WKBundlePageWillRunJavaScriptAlertCallback and willRunJavaScriptAlert  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:75:  Extra space between WKBundlePageWillRunJavaScriptConfirmCallback and willRunJavaScriptConfirm  [whitespace/declaration] [3]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:76:  Extra space between WKBundlePageWillRunJavaScriptPromptCallback and willRunJavaScriptPrompt  [whitespace/declaration] [3]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:63:  _willAddMessageToConsole is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:64:  _willSetStatusbarText is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:65:  _willRunJavaScriptAlert is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:66:  _willRunJavaScriptConfirm is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:67:  _willRunJavaScriptPrompt is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:199:  InjectedBundlePage::_willAddMessageToConsole is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:204:  InjectedBundlePage::_willSetStatusbarText is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:209:  InjectedBundlePage::_willRunJavaScriptAlert is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:214:  InjectedBundlePage::_willRunJavaScriptConfirm is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebKitTools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:219:  InjectedBundlePage::_willRunJavaScriptPrompt is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 15 in 10 files

If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.