[Webkit-unassigned] [Bug 39589] Add LayoutTestController methods to test DeviceOrientation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39589





--- Comment #12 from Steve Block <steveblock at google.com>  2010-07-21 13:00:24 PST ---
> There are many instances in WebKit/DRT codebase where Page() is constructed
> with many of the clients set to 0. All those are valid scenarios, in some cases
> the particular feature is not enabled and in other cases not implemented for
> the platform (e.g. client based geolocation only on few platforms). Wouldn't a
> setter make this relationship clearer, since the optional client parameters
> could be set by the platforms which have these features enabled and the rest
> can safely ignore without passing 0 ?

Agreed.

See also the webkit-dev thread 'Clients and the Page constructor'

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.