[Webkit-unassigned] [Bug 41295] [Chromium] Add chromium WebMediaPlayer to PlatformMedia
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 21 11:38:31 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=41295
Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #61542|review? |review+, commit-queue-
Flag| |
--- Comment #18 from Darin Fisher (:fishd, Google) <fishd at chromium.org> 2010-07-21 11:38:31 PST ---
(From update of attachment 61542)
WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:77
> + WebCore::PlatformMedia pm = element->constUnwrap<HTMLMediaElement>()->platformMedia();
nit: no need for WebCore:: prefix in this file since there is a 'using namespace WebCore'
at the top of the file.
> + WebCore::PlatformMedia pm;
ditto
R=me, but please fix that before committing.WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:174
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list