[Webkit-unassigned] [Bug 5864] feTurbulence is not implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5864





--- Comment #9 from Oliver Hunt <oliver at apple.com>  2010-07-21 09:52:48 PST ---
> WebCore/svg/graphics/filters/SVGFETurbulence.cpp:119
>  +  inline long FETurbulence::PaintingData::random()
> If you want to force inlining, use ALWAYS_INLINE here, consistent with the other filter effects.

I disagree -- ALWAYS_INLINE should only be used if there's a measurable benefit in doing so -- the inline keyword doesn't necessarily guarantee inlining, but it does guarantee sensible linker behaviour.  I don't like the overuse of ALWAYS_INLINE in the filter code.  The purpose of ALWAYS_INLINE is to prevent the compiler from being able to make its own decisions _if_ the compiler is making a measurably incorrect choice.  I have yet to see evidence of this occurring outside of JSC

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.