[Webkit-unassigned] [Bug 37981] implement getData('text/html') for webkit win

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37981





--- Comment #16 from Tony Chang (Google) <tony at chromium.org>  2010-07-20 15:33:45 PST ---
Ok, finally circling back to this patch.  I fixed the style in a separate change so this patch only has the changes necessary for enabling getData("text/html") on windows (Safari win).



(In reply to comment #13)
> (From update of attachment 54123 [details])
> LayoutTests/ChangeLog:6
>  +          https://bugs.webkit.org/show_bug.cgi?id=37981
> Please also mention that 2 layout tests are rebaselined due to the reason you spoke of.

This magically seems to work now, so no rebaselines.

> WebCore/platform/win/ClipboardUtilitiesWin.cpp:394
>  +  String getTextHTML(IDataObject* data, bool& success)
> It might be better to define the function as:
>   bool getTextHTML(IDataObject* data, String& result)

I kept it this way to match the existing methods (getURL and getPlainText).

> WebCore/platform/win/ClipboardUtilitiesWin.cpp:466
>  +      if (SUCCEEDED(data->GetData(htmlFormat(), &store))) {
> This and the following line seem to be identical to getCFHTML. Can you change to call the helper function?

They're the same up until the call to extactMarkupFromCFHTML.  I could refactor the 5 lines before that into a function, but I'm not sure there's much benefit.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.