[Webkit-unassigned] [Bug 42677] New: Chrome browser Bug: Pause button stays when <audio> hits end

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42677

           Summary: Chrome browser Bug: Pause button stays when <audio>
                    hits end
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
               URL: http://code.google.com/p/chromium/issues/detail?id=217
                    39
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: pranavk at chromium.org
                CC: pranavk at chromium.org


This is a copy of bug 21739 on Chrome browser. Please see http://code.google.com/p/chromium/issues/detail?id=21739. Here is the description taken from the bug 21739:

In chrome browser, go to http://en.wikipedia.org/wiki/The_Star-Spangled_Banner and click "play" on one of the media files (right hand side of screen). Notice that when the file hits the end, the "pause" button stays a "pause" button rather than turning into "play". This seems kinda broken. (I would expect the slider to return to the beginning and the button to turn to "play").

The fix of this bug is in WebKit/WebCore/rendering/RenderMediaControlsChromium.cpp. Hence filing this bug. Here is the diff of the fix:

pranavk at pranavk-l1:/usr/local/google/home/pranavk/chrome/src/third_party/WebKit/WebCore$ svn diff
Index: rendering/RenderMediaControlsChromium.cpp
===================================================================
--- rendering/RenderMediaControlsChromium.cpp    (revision 62294)
+++ rendering/RenderMediaControlsChromium.cpp    (working copy)
@@ -96,7 +96,7 @@
     if (!hasSource(mediaElement))
         return paintMediaButton(paintInfo.context, rect, mediaPlayDisabled);

-    return paintMediaButton(paintInfo.context, rect, mediaElement->paused() ? mediaPlay : mediaPause);
+    return paintMediaButton(paintInfo.context, rect, mediaElement->canPlay() ? mediaPlay : mediaPause);
 }

 static Image* getMediaSliderThumb()
pranavk at pranavk-l1:/usr/local/google/home/pranavk/chrome/src/third_party/WebKit/WebCore$

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.