[Webkit-unassigned] [Bug 27156] SplitElementCommand shouldn't be duplicating id attribute

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27156


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |enrica at apple.com,
                   |                            |ojan at chromium.org,
                   |                            |tony at chromium.org
     Ever Confirmed|0                           |1




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2010-07-20 11:32:35 PST ---
(In reply to comment #1)
> If you fix this verify that places that split and then merge soon after will continue to merge even though the second element isn't exactly identical.

I discussed this with Ojan but it seems like we shouldn't be merging elements unless we split the element.  Because imagine you have [hello<b id="test">world</b>] and bold the text.  If we had merged the elements, we'll get [<b id="test">helloworld</b>] but world may have style or some functionality provided by JavaScript.  And merging two elements together may result in loss of functionality.

(In reply to comment #2)
> I'm referring to mergeElementsIfIdentical (I think that's the function name).

areIdenticalElements in ApplyStyleCommand and MergeIdenticalElementsCommand need to be modified to do what you're proposing.

IMHO, the correct approach is not to split elements as much as possible in the first place.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.