[Webkit-unassigned] [Bug 42613] WebScriptObject Should Allow Safely Checking For Key Existence

Tue Jul 20 10:33:40 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=42613

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62031|0                           |1
        is obsolete|                            |
  Attachment #62090|                            |review?
               Flag|                            |

--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org>  2010-07-20 10:33:40 PST ---
Created an attachment (id=62090)
 --> (https://bugs.webkit.org/attachment.cgi?id=62090)
[PATCH] Addressed Comments

(In reply to comment #3)
> This new method should not be added to the public header until it has been through API review.
> Until that time it should be added in the private header in a category on the class named to
> indicate that it’s pending API review.

Done. I put a "forward declaring @interface" in DRT, should I export the Private header instead?

(In reply to comment #4)
> (From update of attachment 62031 [details])
> I’m also not keen on the location you chose for the test case.  The test has nothing to do
> with plugins as far as I can tell.

Ahh, you're correct. I moved it to "LayoutTests/platform/mac/fast/objc/".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.