[Webkit-unassigned] [Bug 42639] Moves various exception code offsets to a central place.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42639





--- Comment #7 from Marcus Bulach <bulach at chromium.org>  2010-07-20 09:58:11 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > I'm not sure if it's possible to check that the offset is being added at compile time unless we make ExceptionCode generally more opaque, but that would be far too large for probably too little benefit.
> 
> I think making ExceptionCode be a struct holding an integer instead of actually being a raw int might be the right direction, and not such a giant project. We can phase it in, using things like a constructor taking and int and operator int at first, and then removing them.

cool! I like doing such refactorings, will plan to do this soon (it's probably not a giant project, but requires some planning on my side..)

meanwhile, I think there's a low-hanging fruit here with the latest patch: it adds compile-time checks, without touching existing code (at the expense of having a new IDL attribute).
would you mind taking a quick look and let me know if you agree with such intermediate step? thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.