[Webkit-unassigned] [Bug 42639] Moves various exception code offsets to a central place.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42639


Marcus Bulach <bulach at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bulach at chromium.org,
                   |                            |darin at apple.com




--- Comment #2 from Marcus Bulach <bulach at chromium.org>  2010-07-20 07:04:13 PST ---
Hi Darin,

This is a follow up on https://bugs.webkit.org/show_bug.cgi?id=42250
The proposed patch is not yet final in the sense that I'll replicate the same idea to a few other places (if it makes sense).

However, I'd appreciate your comments whether or not this is an improvement:
on one hand, it turns on compile-time checking for exception code on the IDL / WebCore, and also adds a centralized place for defining the offsets, hence avoiding possible clashes. On the other hand, it adds a small burden when setting the exception code, as it now needs to offset it (rather than just use the enum value).

Please, let me know your thoughts, and I'd be happy to do the same for the remaining classes.

Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.