[Webkit-unassigned] [Bug 42244] SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42244


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62060|review?                     |review-
               Flag|                            |




--- Comment #12 from Nikolas Zimmermann <zimmermann at kde.org>  2010-07-20 06:29:53 PST ---
(From update of attachment 62060)
Looks great, I have some suggestions though:
It would be great, if all results would end up with the _same_ image. It's much easier to spot breakages, if the expected pngs would all look the same, if the invalidation worked properly - can you change that?
(Are you aware of make-script-test-wrappers, btw? That automatically creates the .html files for you)

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterRes-call.js:45
 +      filterElement.setFilterRes("400", "400");
These take numbers, you can omit the ".

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterResX-prop.js:44
 +      filterElement.filterResX.baseVal = "400";
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-filterResY-prop.js:44
 +      filterElement.filterResY.baseVal = "400";
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-height-prop.js:43
 +      filterElement.height.baseVal.value = "200";
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-width-prop.js:43
 +      filterElement.width.baseVal.value = "200";
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-x-prop.js:43
 +      filterElement.x.baseVal.value = "10";
Ditto.

LayoutTests/svg/dynamic-updates/script-tests/SVGFilterElement-svgdom-y-prop.js:43
 +      filterElement.y.baseVal.value = "10";
Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.