[Webkit-unassigned] [Bug 12499] External <use> xlink:href references do not work

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=12499


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zimmermann at kde.org




--- Comment #31 from Nikolas Zimmermann <zimmermann at kde.org>  2010-07-20 05:45:17 PST ---
(In reply to comment #30)
> Created an attachment (id=62037)
 --> (https://bugs.webkit.org/attachment.cgi?id=62037) [details]
> Patch reworked against trunk
> 
> This is the original patch reworked against master. The main difference is that KURL is better reused now. It is not up for review since a lot needs to be done still:
> 
> - <use> referring an external fragment that uses an external paintserver does not work
> - there is a <use> bug when referring to <symbol>, when not as outer use width/height are not transferred, see batikLogo.svg
> - could still crash with certain testcases
> - cycles are not detected yet
> - needs lots more tests

Hi Rob,

good to see you working again on it. A general comment: I'd propose to refactor the CachedXBLDocument code into a shared CachedDocument class, so that both CachedSVGDocument & CachedXBLDocument can inherit from it.

Cheers,
Niko

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.