[Webkit-unassigned] [Bug 42068] Need to be able to configure Geolocation policy regarding user permissions

Tue Jul 20 02:29:14 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=42068

Steve Block <steveblock at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62044|review?                     |review-
               Flag|                            |

--- Comment #8 from Steve Block <steveblock at google.com>  2010-07-20 02:29:14 PST ---
(From update of attachment 62044)
WebCore/page/Geolocation.cpp:643
 +  #endif 
Trailing whitespace

WebCore/page/Geolocation.cpp:421
 +              m_startRequestPermissionNotifier = 0;
This new block wasn't in the first patch and introduces a change in behaviour. This bug was intended to add the new USE flag and not introduce any functional changes. This block should be part of the fix for your original Bug 42027.

JavaScriptCore/wtf/Platform.h:1120
 +  #if ENABLE(CLIENT_BASED_GEOLOCATION)
I still think a comment describing the currently supported permutations would be good.

It looks like you still plan to use the non-client-based implementation on Qt? It would be great of you could go straight for the client-based approach.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.