[Webkit-unassigned] [Bug 42603] Add a mock and LayoutTestController bindings for speech input.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42603





--- Comment #2 from Steve Block <steveblock at google.com>  2010-07-20 01:51:23 PST ---
(From update of attachment 62009)
WebKit/mac/WebView/WebViewPrivate.h:171
 +      @method setMockSpeechInputResult:
Should this be in its own '@interface WebView (WebViewSpeech)' ?

WebCore/page/SpeechInputClientMock.cpp:51
 +      m_timer.startOneShot(0);
This will restart the timer if it's already running. Is this desired? Does the SpeechInput offer any protection against this?

LayoutTests/ChangeLog: 
 +          * platform/mac/editing/pasteboard/subframe-dragndrop-1-expected.che
??

LayoutTests/fast/forms/script-tests/input-text-speechbutton.js:1
 +  description('Tests for speech button click with <input type=text speech>.');
Do you need to use &lt here?

LayoutTests/fast/forms/script-tests/input-text-speechbutton.js:6
 +  }
It might be good to add a debug message that this test will fail outside DumpRenderTree, when layoutTestController is not available.

LayoutTests/fast/forms/script-tests/input-text-speechbutton.js:16
 +          layoutTestController.notifyDone();
You can use window.jsTestIsAsync and finishJSTest(), in place of waitUntilDone() and notifyDone(). This also adds the 'TEST COMPLETE' output which is currently missing. See fast/dom/Geolocation/script-tests/success.js.

LayoutTests/platform/chromium/test_expectations.txt:2925
 +  BUG44844: fast/forms/input-text-speechbutton.html = TEXT
Would it be better to add a new directory for the speech tests to keep them grouped together? You could then just add the directory to the skipped lists (other than for GTK).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.