[Webkit-unassigned] [Bug 42278] Removes DontCheckEnums from some IDLs and fixes the corresponding enums.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42278





--- Comment #8 from Marcus Bulach <bulach at chromium.org>  2010-07-19 07:18:35 PST ---
(In reply to comment #3)
> (From update of attachment 61550 [details])
> >          enum orientType {
> > -            VERTICAL   = 0,
> > -            HORIZONTAL = 1,
> > +            HORIZONTAL = 0,
> > +            VERTICAL   = 1,
> >              BOTH       = 2
> >          };
> 
> This change seems risky. Was there any C++ code using these constants and thus getting things wrong? Can we construct a test that demonstrates we had them wrong?
> 
> The rest of the changes seem obviously good.

sorry to bother you again: there was an existing test (fast/events/overflow-events.html) that failed with this change.

the issue being that it tested against the numeric hardcoded values, and looks like it assumed the C++ side rather than the IDL definitions.

I changed the test to remove the hardcoded values and use the IDL-defined consts instead, would you mind taking another look? thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.