[Webkit-unassigned] [Bug 42380] Add WebCore/bindings/generic/RuntimeEnabledFeatures.cpp to build files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42380





--- Comment #12 from hans at chromium.org  2010-07-19 03:22:00 PST ---
(In reply to comment #11)
> (From update of attachment 61931 [details])
> It would be good to describe the motivation for this patch in the bug.
The motivation is to make the functions in RuntimeEnabledFeatures.h available in WebCore so that the device orientation code can add an use an enable-switch here. I'd love to add this to the description of the bug, but I don't think it can be edited?

> 
> > bindings/generic a while a go (in r54593), but needs to
> needs -> need
Done.

> 
> > be added to the build in order to be used.
> Add a tests line, saying that there are no new tests because this patch introduces no change in functionality
Done.

> 
> > WebCore/WebCore.vcproj/WebCore.vcproj
> Did you make the change by hand, or with VisualStudio?
By hand, as I don't have access to the supported Visual Studio version. This is why I'm anxious to have a Win bot test it.

> 
> > WebCore/page/Page.cpp
> Did you intend this change to be submitted, or is just for testing on the bots?
It's just to make sure the bots fail if the .h file fails to be included.

I was planning to take it out when all the EWS bots were green, but if we can't get the Win EWS bot to run this patch, perhaps we should leave it in so it gets tested by the real bots?

> 
> I'll help you land the patch manually if the Win EWS bot continues to give problems.
Thanks. Much appreciated.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.