[Webkit-unassigned] [Bug 34913] Unpainted white area appears at the edge of the page when body has bg color

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34913





--- Comment #21 from mitz at webkit.org  2010-07-18 19:53:29 PST ---
(In reply to comment #20)
> (From update of attachment 61897 [details])
> > Index: WebCore/rendering/RenderObjectChildList.cpp
> > ===================================================================
> > --- WebCore/rendering/RenderObjectChildList.cpp	(revision 63603)
> > +++ WebCore/rendering/RenderObjectChildList.cpp	(working copy)
> > @@ -62,9 +62,11 @@ RenderObject* RenderObjectChildList::rem
> >      // disappears gets repainted properly.
> >      if (!owner->documentBeingDestroyed() && fullRemove && oldChild->m_everHadLayout) {
> >          oldChild->setNeedsLayoutAndPrefWidthsRecalc();
> > +        if (oldChild->isBody())
> > +            owner->view()->repaint();
> >          oldChild->repaint();
> 
> Shouldn't this get an else rather than arbitrarily repainting oldChild? Otherwise we end up computing the dirty rect for all intersecting elements unnecessarily don't we?

If oldChild is the body renderer, the oldChild->repaint() computes that renderer’s and only that renderer’s repaint rect, a computation whose complexity is linear in the number of ancestors (typically 2 in this case). I can add “else” when landing.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.