[Webkit-unassigned] [Bug 42523] Web Inspector: the bindings generation helper script can be simplified a bit. Chromium.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42523


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61909|review?                     |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2010-07-18 13:33:35 PST ---
(From update of attachment 61909)
A bunch of nits to fix.

WebCore/WebCore.gyp/scripts/rule_binding.py:124
 +      command.extend(['--outputHDir', hdir])
Here and below outputHeadersDir

WebCore/WebCore.gyp/scripts/rule_binding.py: 
 +      # Both the .cpp and .h were generated in cppdir, but if hdir is different,
Can you avoid changing this behavior?

WebCore/bindings/scripts/CodeGenerator.pm:112
 +      $codeGenerator = $ifaceName->new($object, $useOutputDir, $useLayerOnTop, $preprocessor, $writeDependencies, $verbose, $useOutputHDir);
I'd keep useOutputDir and useOutputHeadersDir next to each other.

WebCore/inspector/CodeGeneratorInspector.pm:282
 +      open(my $HEADER, ">$outputHDir/$frontendClassName.h") || die "Couldn't open file $outputDir/$frontendClassName.h";
print HeadersDir, not Dir in the message.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.