[Webkit-unassigned] [Bug 42217] Webkit crashes while loading gallery.me.com

Sat Jul 17 21:32:39 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=42217

--- Comment #8 from Alexey Proskuryakov <ap at webkit.org>  2010-07-17 21:32:39 PST ---
> Have you seen the patch itself? 

Yes, the lack of tests looked suspicious to me even before I saw this bug, but I didn't speak up until I saw that the symptom was user observable (yes, it is possible that some early deletes don't cause crashes, at least unless there is another thread doing memory allocation at the moment).

> Previous commit from that bug actually made some tests fail on Chromium Win Debug.

OK, then we already have regression tests for this change, and it's only a ChangeLog entry that was misleading. 

> how do we address accessing freed memory in layout tests

Sometimes, it suffices to add an assertion that catches a bug in debug builds, although that's a pretty weak regression test. Other times, it's actually possible to empirically find a test that crashes.

Being unable to make a regression test is a fair explanation that is up to a reviewer to assess. In this case, I'd have likely agreed that's it was impossible. But this bug would have proven us wrong, since it should be possible to reduce this real life case to a regression test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.