[Webkit-unassigned] [Bug 42220] [chromium] Subpixel rendering always disabled on Linux

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42220


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61835|review?                     |review+
               Flag|                            |




--- Comment #13 from Ojan Vafai <ojan at chromium.org>  2010-07-16 17:06:55 PST ---
(From update of attachment 61835)
> +++ b/LayoutTests/ChangeLog
> +        Layout test addition to check that Chromium Linux honors fontconfig
> +        settings enabling or disabling subpixel rendering per-strike.
> +
> +        Subpixel rendering always disabled for Chromium Linux
> +        https://bugs.webkit.org/show_bug.cgi?id=42220

Nit: the detailed description should go below the bug line, i.e.:

> +        Subpixel rendering always disabled for Chromium Linux
> +        https://bugs.webkit.org/show_bug.cgi?id=42220
> +
> +        Layout test addition to check that Chromium Linux honors fontconfig
> +        settings enabling or disabling subpixel rendering per-strike.

> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,16 @@
> +        Initialize global Chromium Linux isSkiaSubpixelGlyphs flag to false.
> +        (I believe that Chromium is always initializing this before using
> +        it, but it scares me all the same.)
> +
> +        Subpixel rendering always disabled for Chromium Linux
> +        https://bugs.webkit.org/show_bug.cgi?id=42220

Ditto.

> +        Honor Fontconfig subpixel rendering setting on Chromium Linux.
> +
> +        Subpixel rendering always disabled for Chromium Linux
> +        https://bugs.webkit.org/show_bug.cgi?id=42220

And same here. :)

When you've made these changes, you can post a new patch and any committer can set cq+ to put it in the commit queue. No need for another review.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.