[Webkit-unassigned] [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=27551





--- Comment #61 from Kevin Ollivier <kevino at theolliviers.com>  2010-07-16 11:35:10 PST ---
So the Chromium problem is a simple JS_EXPORTDATA -> JS_EXPORTED_SYMBOL change in their DRT config.h header, but again the Win bot can't apply the Win project changes to the patch, and I don't think that will change if I update a new patch with the Chromium fix. I really have to move on to addressing some other problems for now, so I'll get back to this when I can, but if someone wants to give it a shot before then, the place to start from would probably be the "Use JS_EXPORT_PRIVATE to export individual symbols" patch. 

Note that having gone through and made fixes for most of the ports, one thing I would probably do if I had to do it again is have some separate JSCore header for the defines. (And maybe a WTF one too, for projects only including WTF headers.) Maybe JSConfig.h and WTFConfig.h? Then in config.h or similar project headers, I'd include the JSCore / WTF header. This way, JS_EXPORTED_SYMBOL is only defined in one place rather than having a lot of copied and pasted re-definitions and would be defined based on a combination of JS_EXPORT + BUILDING_<JavaScriptCore/WTF> values.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.